Showing posts with label Core Reviews. Show all posts
Showing posts with label Core Reviews. Show all posts

Tuesday, October 30, 2007

A painful pseudo-discussion

I came across this little informational post on code inspections. Seems like a little bit more of a formalized process to how we do our current code reviews. I like the encouragement of getting everyone involved in the process though, which is something I fell is missing from most code reviews. No matter how much you try to get everyone to participate, it turns into more of a presentation by the senior team to the rest of the developers. One section that really caught my eye, though:

Motley: That still looks pretty formal and heavy to me! Just the fact that you have a diagram describing all the steps is a little scary. I'm worried this practice is going to suck up a lot of time.

Maven: Ah, don't be afraid. The process is actually quite simple and not unlike other code reviews. It's just a little more structured with a couple of key practices to ensure that reviewers are highly effective. First we start with planning.

Motley: Yeah, the process is so complicated I bet you need a plan just to pull it off!


We have someone at work you is almost exactly like the antagonist in this little one act play and I can't scream loudly enough how much of a poison pill this person is to the team and morale. If you have someone around like this, I would highly recommend doing whatever you can to keep them at arms length from your projects. True Believer Agilista's can be dangerous.